From c4ba9ef2d295f85897557ce1f841a8bb368ed5ee Mon Sep 17 00:00:00 2001 From: Christian Weiske Date: Thu, 21 Mar 2013 06:39:11 +0100 Subject: [PATCH] add (broken) tests for Services_Tag::normalize and Bookmark2Tag::attachTags with some empty tags --- tests/Bookmark2TagTest.php | 10 +++++++++- tests/TagTest.php | 8 ++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/tests/Bookmark2TagTest.php b/tests/Bookmark2TagTest.php index f466a7d..b0eccd1 100644 --- a/tests/Bookmark2TagTest.php +++ b/tests/Bookmark2TagTest.php @@ -89,7 +89,15 @@ class Bookmark2TagTest extends TestBase ); } - + public function testAttachTagsWithSomeEmptyTags() + { + $bid = $this->addBookmark(null, null, 0, array()); + $this->b2ts->attachTags($bid, array('foo', '', 'bar', 'baz')); + $this->assertEquals( + array('foo', 'bar', 'baz'), + $this->b2ts->getTagsForBookmark($bid) + ); + } /** * Test getTagsForBookmark() when the bookmark has no tags diff --git a/tests/TagTest.php b/tests/TagTest.php index 96f3f14..bda5a29 100644 --- a/tests/TagTest.php +++ b/tests/TagTest.php @@ -87,5 +87,13 @@ class TagTest extends TestBase } + public function testNormalizeEmptyValues() + { + $tags = $this->ts->normalize( + array('foo', '', 'bar', 'baz') + ); + $this->assertEquals(array('foo', 'bar', 'baz'), $tags); + } + } ?>